tubbo released this
Oct 17, 2019
· 145 commits to master since this release
Patch release notes for Workarea 3.4.19.
Sprockets v4.0 was released on 10/8/2019, which removed the .register_engine method that is depended on by many extensions to Sprockets at the current moment. Lock down Sprockets to v3.7.2 to avoid these issues, which will show up when the app is loaded or tests are run.
When adding a customized field to a Customizations class that ends in _id, Workarea was previously stripping this suffix from the computed instance variable name that is converted into snake case from any kind of input. This causes issues because the data doesn't appear to be making it into customizations, but is really there under a different instance variable name. To resolve the issue, Workarea now detects whether a variable is already using snake case and leaves it alone...only providing transformations for variable names that need it.
The admin toolbar is loaded within an <iframe>, which makes Capybara unable to determine when it's been loaded. As a result, Capybara attempts to perform actions on the element when it has not fully loaded, which results in failing tests on CI. While there doesn't seem to be a definitive solution to this issue, a sleep has been added prior to testing markup in the <iframe> in order to get tests passing for now. In the future, the admin toolbar will no longer be loaded within an <iframe>, which will avoid this problem by v3.6.
Faraday released breaking changes in v0.16.0 that were not properly supported by our required version of the Elasticsearch gem. This caused builds to fail with strange Faraday errors and an inability to connect to the server. Locking down Faraday to the latest v0.15 version has resolved the issues in builds.
A UX improvement to how changesets are ordered in the timeline. They will now be rendered in the following order:
Adding the same ID to a category product rule matching the product list that contains it results in some wonky results coming back. This was originally diagnosed as an issue when combining category rules, but in reality, it has to do with an admin mis-using the product rules interface and perhaps accidentally using the category's own ID in a product rule. To prevent this from happening, Workarea now cleans the current product_list.id from the value if a category rule is created or updated.
This magic attribute doesn't need to be calculated, it's the inverse of the aspect ratio we already have. Relying on the magic attributes for this would require re-saving each model instance.
tubbo released this
Oct 2, 2019
· 119 commits to master since this release
Add the storefront.checkout_confirmation_text append point below the workarea.storefront.checkouts.confirmation_text copy in storefront.
ProductViewModel#default_category now protects against a nil value for the default category before passing its value into a view model. This caused an issue for a brand new install when no categories have been added yet.
Due to the length of URLs being displayed on Order Attributes in the admin they will potentially break layout. Now they are displayed within a tooltip behind a "View" link click. The resulting tooltip will prompt the user to copy the contents of a text box containing the URL.
The plugin template has been overhauled to work with open source-derived Workarea code, and some additional fixes for plugin developers to make things easier. A short list:
Populate the :image_inverse_aspect_ratio automatically using Dragonfly, in order to reduce the amount of requests made to S3 in order to find out this information. This way, Dragonfly can store more assets in the cache.
When inserting tags into a taggable document, make sure their values are unique. This addresses an issue where incorrect tag counts were being displayed on the storefront.
tubbo released this
Sep 24, 2019
· 77 commits to master since this release
Patch release notes for Workarea 3.4.16.
It's currently possible to customize search queries that return an exact match, but instead of seeing the customized results when you run the query, you'll be redirected to the product page since the StorefrontSearch::ExactMatches middleware stops further middleware from running and sets a redirect to the product path. To resolve the issue, Workarea will now ignore this middleware if a customization is present on the search response.
Discovered by Ryan Tulino of Syatt Media. Thanks Ryan!
Remove a check for whether a given audit log entry is #restorable? in on the /admin/trash page to prevent empty results clogging up the pagination. Without this, admins will see blank pages if they delete enough nav taxon/release records at the same time.
Additionally, due to render_activity_entry rescuing a template error to return a blank string, results were still being seen in the trash when a model that doesn't explicitly have an activity partial defined is encountered. To resolve this issue, models that are tracked by Mongoid::AuditLog, without an explicit activity partial defined will be rendered using a generic partial, showing the class name and ID of the audited model, as something to render in the listing so that pages of blank results aren't shown.
Direct uploads can fail locally if your Workarea.config.host is not set to the domain you are currently using in the browser. To prevent this, instead of reading from the configuration when ensuring CORS headers on the S3 bucket, use the ActionDispatch::Request from the controller to determine the correct URL for CORS in this instance. Addresses a problem whereby changing the domain (either accidentally or on-purpose) causes direct uploads to fail, since it can't create the proper CORS headers needed to transmit files into the bucket directly.
Ensure test only asserts product details in ProductSystemTest. Recently viewed products were being accidentally clicked on and thus the incorrect information is being rendered to the screen, causing the test to fail. Scope selectors to the product details component to avoid this.
meowsus released this
Aug 27, 2019
· 12 commits to master since this release